]> git.ipfire.org Git - thirdparty/libvirt.git/commit
nwfilter: address coverity findings
authorStefan Berger <stefanb@linux.vnet.ibm.com>
Thu, 26 Apr 2012 20:45:36 +0000 (16:45 -0400)
committerCole Robinson <crobinso@redhat.com>
Fri, 27 Apr 2012 18:17:01 +0000 (14:17 -0400)
commit18adb6cf82e406e507a899493b188fd9cf624fa9
treea63de5e716dd7d56907e58c413eb589647fea8e6
parentd9f909d4cd8e51d26d2524b47914915bc20e0673
nwfilter: address coverity findings

This patch addresses the following coverity findings:

/libvirt/src/conf/nwfilter_params.c:157:
deref_parm: Directly dereferencing parameter "val".

/libvirt/src/conf/nwfilter_params.c:473:
negative_returns: Using variable "iterIndex" as an index to array "res->iter".

/libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2891:
unchecked_value: No check of the return value of "virAsprintf(&protostr, "-d 01:80:c2:00:00:00 ")".

/libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2894:
unchecked_value: No check of the return value of "virAsprintf(&protostr, "-p 0x%04x ", l3_protocols[protoidx].attr)".

/libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:3590:
var_deref_op: Dereferencing null variable "inst".
src/conf/nwfilter_params.c
src/nwfilter/nwfilter_ebiptables_driver.c