]> git.ipfire.org Git - thirdparty/linux.git/commit
net: usb: lan78xx: Use ETIMEDOUT instead of ETIME in lan78xx_stop_hw
authorOleksij Rempel <o.rempel@pengutronix.de>
Mon, 16 Dec 2024 12:09:37 +0000 (13:09 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Dec 2024 03:51:54 +0000 (19:51 -0800)
commit18bdefe62439c75227021ddbbf6510aa2f2f4e54
treedbfef1ac7f36ce88053403bf0628cef811dc0596
parent30c63abaee9024ed7524325b3eeb7f2d26727c31
net: usb: lan78xx: Use ETIMEDOUT instead of ETIME in lan78xx_stop_hw

Update lan78xx_stop_hw to return -ETIMEDOUT instead of -ETIME when
a timeout occurs. While -ETIME indicates a general timer expiration,
-ETIMEDOUT is more commonly used for signaling operation timeouts and
provides better consistency with standard error handling in the driver.

The -ETIME checks in tx_complete() and rx_complete() are unrelated to
this error handling change. In these functions, the error values are derived
from urb->status, which reflects USB transfer errors. The error value from
lan78xx_stop_hw will be exposed in the following cases:
- usb_driver::suspend
- net_device_ops::ndo_stop (potentially, though currently the return value
  is not used).

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Link: https://patch.msgid.link/20241216120941.1690908-3-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/lan78xx.c