]> git.ipfire.org Git - thirdparty/qemu.git/commit
ssh: Don't crash if either host or path is not specified.
authorRichard W.M. Jones <rjones@redhat.com>
Mon, 29 Sep 2014 08:06:22 +0000 (09:06 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 3 Oct 2014 09:30:33 +0000 (10:30 +0100)
commit18fe46d79a6de61cb2c379fb610d834ef658d84b
tree71e3ede0355d954c5c8639a72f601f259826d15c
parentaf957387547b05ed6dc4d84c10cca42700a7aeda
ssh: Don't crash if either host or path is not specified.

$ ./qemu-img create -f qcow2 overlay \
    -b 'json: { "file.driver":"ssh",
                "file.host":"localhost",
                "file.host_key_check":"no" }'
qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `obj != ((void *)0)' failed.
Aborted

A similar crash also happens if the file.host field is omitted.

https://bugzilla.redhat.com/show_bug.cgi?id=1147343

Bug found and reported by Jun Li.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/ssh.c