]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: gadget: serial: fix Tx stall after buffer overflow
authorSergey Organov <sorganov@gmail.com>
Wed, 29 Jan 2020 11:21:46 +0000 (14:21 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Mar 2020 06:18:24 +0000 (07:18 +0100)
commit1927cc4b770a07d2da98d5b251a6d6bc22ffc1ad
tree1f5264880b0813dcf3e0a1f2d0df2c7fcd99b194
parentf2ec3d423cbdb3dd705b0df28607a19100d0a77e
usb: gadget: serial: fix Tx stall after buffer overflow

[ Upstream commit e4bfded56cf39b8d02733c1e6ef546b97961e18a ]

Symptom: application opens /dev/ttyGS0 and starts sending (writing) to
it while either USB cable is not connected, or nobody listens on the
other side of the cable. If driver circular buffer overflows before
connection is established, no data will be written to the USB layer
until/unless /dev/ttyGS0 is closed and re-opened again by the
application (the latter besides having no means of being notified about
the event of establishing of the connection.)

Fix: on open and/or connect, kick Tx to flush circular buffer data to
USB layer.

Signed-off-by: Sergey Organov <sorganov@gmail.com>
Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/function/u_serial.c