]> git.ipfire.org Git - thirdparty/ipxe.git/commit
[efi] Report local file errors during download, rather than on opening
authorMichael Brown <mcb30@ipxe.org>
Fri, 29 Mar 2024 13:32:25 +0000 (13:32 +0000)
committerMichael Brown <mcb30@ipxe.org>
Fri, 29 Mar 2024 14:41:06 +0000 (14:41 +0000)
commit19f39bc07a82ac589cd2fa360b6f32c15d0eb0a8
treed72c071dec9641d3996d3198edf0bedbdb951032
parentf39b48d5f82793c75700b0787b36f65d33079f3b
[efi] Report local file errors during download, rather than on opening

iPXE is designed around fully asynchronous I/O, including asynchronous
connection opening.  Almost all errors are therefore necessarily
reported as occurring during an in-progress download, rather than
occurring at the time that the URI is opened.

Local file access is currently an exception to this: errors such as
nonexistent files will be encountered while opening the URI.  This
results in mildly unexpected error messages of the form "Could not
start download", rather than the usual pattern of showing the URI, the
initial progress dots, and then the error message.

Fix this inconsistency by deferring the local filesystem access until
the local file download process is running.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/interface/efi/efi_local.c