]> git.ipfire.org Git - thirdparty/libvirt.git/commit
graphics: remember graphics not auto allocated ports
authorGiuseppe Scrivano <gscrivan@redhat.com>
Tue, 24 Jun 2014 11:34:18 +0000 (13:34 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 24 Jun 2014 12:17:59 +0000 (14:17 +0200)
commit1a065caa79bb4e42178a9e431ddbe5550a1c0596
treeb2d9b066cab22b11afc82f28d535a5ce466e3d63
parent1d8d2fbcd09b26541db580f456e6a873869b0abe
graphics: remember graphics not auto allocated ports

When looking for a port to allocate, the port allocator didn't take in
consideration ports that are statically set by the user.  Defining
these two graphics elements in the XML would cause an error, as the
port allocator would try to use the same port for the spice graphics
element:

    <graphics type='spice' autoport='yes'/>
    <graphics type='vnc' port='5900' autoport='no'/>

The new *[pP]ortReserved variables keep track of the ports that were
successfully tracked as used by the port allocator but that weren't
bound.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1081881
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
src/conf/domain_conf.h
src/qemu/qemu_process.c