]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid scribbling on input node tree in CREATE/ALTER DOMAIN.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Jun 2021 16:09:22 +0000 (12:09 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Jun 2021 16:09:22 +0000 (12:09 -0400)
commit1a3d30255a4e821445927ca0949f00364de660fd
treea78e18946b095bbd645b48cb7bd6ccf9f931ac2d
parentec52b886d1dd8c08993b391753d450488e18f330
Avoid scribbling on input node tree in CREATE/ALTER DOMAIN.

This works fine in the "simple Query" code path; but if the
statement is in the plan cache then it's corrupted for future
re-execution.  Apply copyObject() to protect the original
tree from modification, as we've done elsewhere.

This narrow fix is applied only to the back branches.  In HEAD,
the problem was fixed more generally by commit 7c337b6b5; but
that changed ProcessUtility's API, so it's infeasible to
back-patch.

Per bug #17053 from Charles Samborski.

Discussion: https://postgr.es/m/931771.1623893989@sss.pgh.pa.us
Discussion: https://postgr.es/m/17053-3ca3f501bbc212b4@postgresql.org
src/backend/commands/typecmds.c