]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/i386: Fix legacy page table walk
authorAlexander Graf <graf@amazon.com>
Wed, 6 Nov 2024 15:43:29 +0000 (15:43 +0000)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 13 Nov 2024 15:17:37 +0000 (18:17 +0300)
commit1a629dc2f20ab8a4e619cb12d69284d8641c4e56
treec4ba9d05f44dee5f75357d013e232502a65cf13b
parent5f590d437ca0fb1eb98fa3315e2fcbf0e13110d2
target/i386: Fix legacy page table walk

Commit b56617bbcb4 ("target/i386: Walk NPT in guest real mode") added
logic to run the page table walker even in real mode if we are in NPT
mode.  That function then determined whether real mode or paging is
active based on whether the pg_mode variable was 0.

Unfortunately pg_mode is 0 in two situations:

  1) Paging is disabled (real mode)
  2) Paging is in 2-level paging mode (32bit without PAE)

That means the walker now assumed that 2-level paging mode was real
mode, breaking NetBSD as well as Windows XP.

To fix that, this patch adds a new PG flag to pg_mode which indicates
whether paging is active at all and uses that to determine whether we
are in real mode or not.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2654
Fixes: b56617bbcb4 ("target/i386: Walk NPT in guest real mode")
Fixes: 58dc0a07a2b (commit b56617bbcb4 in stable-9.0.x series)
Signed-off-by: Alexander Graf <graf@amazon.com>
Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Link: https://lore.kernel.org/r/20241106154329.67218-1-graf@amazon.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 8fa11a4df344f58375eb26b3b65004345f21ef37)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/i386/cpu.h
target/i386/tcg/seg_helper.c
target/i386/tcg/sysemu/excp_helper.c