]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
x86/devmem: Remove duplicate range_is_allowed() definition
authorDan Williams <dan.j.williams@intel.com>
Wed, 30 Apr 2025 02:46:21 +0000 (19:46 -0700)
committerDave Hansen <dave.hansen@linux.intel.com>
Thu, 1 May 2025 16:43:48 +0000 (09:43 -0700)
commit1b3f2bd04d90f61e1f291b5e365b9bc4ce0ea7c7
tree1ea766f39a277a5b1305905e64aa187da0d7c954
parenteaa607deb29e0b6fd24b9adf230fbc765f342521
x86/devmem: Remove duplicate range_is_allowed() definition

17 years ago, Venki suggested [1] "A future improvement would be to
avoid the range_is_allowed duplication".

The only thing preventing a common implementation is that
phys_mem_access_prot_allowed() expects the range check to exit
immediately when PAT is disabled [2]. I.e. there is no cache conflict to
manage in that case. This cleanup was noticed on the path to
considering changing range_is_allowed() policy to blanket deny /dev/mem
for private (confidential computing) memory.

Note, however that phys_mem_access_prot_allowed() has long since stopped
being relevant for managing cache-type validation due to [3], and [4].

Commit 0124cecfc85a ("x86, PAT: disable /dev/mem mmap RAM with PAT") [1]
Commit 9e41bff2708e ("x86: fix /dev/mem mmap breakage when PAT is disabled") [2]
Commit 1886297ce0c8 ("x86/mm/pat: Fix BUG_ON() in mmap_mem() on QEMU/i386") [3]
Commit 0c3c8a18361a ("x86, PAT: Remove duplicate memtype reserve in devmem mmap") [4]

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/all/20250430024622.1134277-2-dan.j.williams%40intel.com
arch/x86/mm/pat/memtype.c
drivers/char/mem.c
include/linux/io.h