]> git.ipfire.org Git - thirdparty/qemu.git/commit
physmem: teach cpu_memory_rw_debug() to write to more memory regions
authorDavid Hildenbrand <david@redhat.com>
Mon, 10 Feb 2025 08:46:48 +0000 (09:46 +0100)
committerPeter Xu <peterx@redhat.com>
Wed, 12 Feb 2025 16:33:13 +0000 (11:33 -0500)
commit1cceedd7726556052d3d3bcf08a07b7762f8aa7c
tree696beb53b8e891747cc433d1dcb39bc921508166
parent425ce9b37b98799b46cd0bed0df3dc3af25ba57a
physmem: teach cpu_memory_rw_debug() to write to more memory regions

Right now, we only allow for writing to memory regions that allow direct
access using memcpy etc; all other writes are simply ignored. This
implies that debugging guests will not work as expected when writing
to MMIO device regions.

Let's extend cpu_memory_rw_debug() to write to more memory regions,
including MMIO device regions. Reshuffle the condition in
memory_access_is_direct() to make it easier to read and add a comment.

While this change implies that debug access can now also write to MMIO
devices, we now are also permit ELF image loads and similar users of
cpu_memory_rw_debug() to write to MMIO devices; currently we ignore
these writes.

Peter assumes [1] that there's probably a class of guest images, which
will start writing junk (likely zeroes) into device model registers; we
previously would silently ignore any such bogus ELF sections. Likely
these images are of questionable correctness and this can be ignored. If
ever a problem, we could make these cases use address_space_write_rom()
instead, which is left unchanged for now.

This patch is based on previous work by Stefan Zabka.

[1] https://lore.kernel.org/all/CAFEAcA_2CEJKFyjvbwmpt=on=GgMVamQ5hiiVt+zUr6AY3X=Xg@mail.gmail.com/

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/213
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20250210084648.33798-8-david@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
hw/core/cpu-system.c
include/exec/memattrs.h
include/exec/memory.h
system/physmem.c