]> git.ipfire.org Git - thirdparty/qemu.git/commit
monitor: Drop monitor_fdset_dup_fd_find/_remove()
authorPeter Xu <peterx@redhat.com>
Mon, 17 Jun 2024 18:57:20 +0000 (15:57 -0300)
committerFabiano Rosas <farosas@suse.de>
Thu, 20 Jun 2024 13:42:24 +0000 (10:42 -0300)
commit1cd93fb0bf8b1fddab4c38e17145cc8776eadaa0
treef09602edbb8ff11353ffb618095eec870bc6af33
parent926554c0bfdfbf7b058ed370c2b484e56b126d34
monitor: Drop monitor_fdset_dup_fd_find/_remove()

Those functions are not needed, one remove function should already
work.  Clean it up.

Here the code doesn't really care about whether we need to keep that dupfd
around if close() failed: when that happens something got very wrong,
keeping the dup_fd around the fdsets may not help that situation so far.

Cc: Dr. David Alan Gilbert <dave@treblig.org>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
[add missing return statement, removal during traversal is not safe]
Signed-off-by: Fabiano Rosas <farosas@suse.de>
include/monitor/monitor.h
monitor/fds.c
stubs/fdset.c
util/osdep.c