]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_dump: Fix dumping of inherited generated columns
authorPeter Eisentraut <peter@eisentraut.org>
Wed, 3 Feb 2021 10:27:13 +0000 (11:27 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 3 Feb 2021 10:43:01 +0000 (11:43 +0100)
commit1d3ce0223c6a527c2f464fb8e6b3874be4e7332e
treed5b729a4a6123a4db3e5136f6d77e13ce7266b94
parent0fe8b1f7d48ed2d5f50d6583481f70d2ebf2a073
pg_dump: Fix dumping of inherited generated columns

Generation expressions of generated columns are always inherited, so
there is no need to set them separately in child tables, and there is
no syntax to do so either.  The code previously used the code paths
for the handling of default values, for which different rules apply;
in particular it might want to set a default value explicitly for an
inherited column.  This resulted in unrestorable dumps.  For generated
columns, just skip them in inherited tables.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/15830.1575468847%40sss.pgh.pa.us
src/bin/pg_dump/common.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/t/002_pg_dump.pl