]> git.ipfire.org Git - thirdparty/linux.git/commit
EDAC: Initialize EDAC features sysfs attributes
authorShiju Jose <shiju.jose@huawei.com>
Thu, 26 Jun 2025 10:13:44 +0000 (11:13 +0100)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 30 Jun 2025 08:57:24 +0000 (10:57 +0200)
commit1e14ea901dc8d976d355ddc3e0de84ee86ef0596
treee9a8151c88aa37227f6f332e5e5b4a80453fb8f2
parenta3f3040657417aeadb9622c629d4a0c2693a0f93
EDAC: Initialize EDAC features sysfs attributes

Fix the lockdep splat caused by missing sysfs_attr_init() calls for the
recently added EDAC feature's sysfs attributes.

In lockdep_init_map_type(), the check for the lock-class key if
(!static_obj(key) && !is_dynamic_key(key)) causes the splat.

  Backtrace:
  RIP: 0010:lockdep_init_map_type
  Call Trace:
   __kernfs_create_file
  sysfs_add_file_mode_ns
  internal_create_group
  internal_create_groups
  device_add
  ? __init_waitqueue_head
  edac_dev_register
  devm_cxl_memdev_edac_register
  ? lock_acquire
  ? find_held_lock
  ? cxl_mem_probe
  ? cxl_mem_probe
  ? lockdep_hardirqs_on
  ? cxl_mem_probe
  cxl_mem_probe

  [ bp: Massage. ]

Fixes: f90b738166fe ("EDAC: Add scrub control feature")
Fixes: bcbd069b11b0 ("EDAC: Add a Error Check Scrub control feature")
Fixes: 699ea5219c4b ("EDAC: Add a memory repair control feature")
Reported-by: Dave Jiang <dave.jiang@intel.com>
Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Link: https://lore.kernel.org/20250626101344.1726-1-shiju.jose@huawei.com
drivers/edac/ecs.c
drivers/edac/mem_repair.c
drivers/edac/scrub.c