]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drivers: usb: smsusb: fix error handling code in smsusb_init_device
authorDongliang Mu <dzm91@hust.edu.cn>
Mon, 27 Feb 2023 10:24:08 +0000 (18:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Sep 2023 08:46:57 +0000 (10:46 +0200)
commit1e9c416e288ad1e670dd08bfb6a0bc659b594ee7
tree52dfd38198ed1efe3044722fd77970d51fc2a87a
parent82e36f0c287769a0430268739a71dbd56df0e679
drivers: usb: smsusb: fix error handling code in smsusb_init_device

[ Upstream commit b9c7141f384097fa4fa67d2f72e5731d628aef7c ]

The previous commit 4b208f8b561f ("[media] siano: register media controller
earlier")moves siano_media_device_register before smscore_register_device,
and adds corresponding error handling code if smscore_register_device
fails. However, it misses the following error handling code of
smsusb_init_device.

Fix this by moving error handling code at the end of smsusb_init_device
and adding a goto statement in the following error handling parts.

Fixes: 4b208f8b561f ("[media] siano: register media controller earlier")
Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/siano/smsusb.c