]> git.ipfire.org Git - thirdparty/qemu.git/commit
checkpatch: better pattern for inline comments
authorMichael S. Tsirkin <mst@redhat.com>
Mon, 7 Nov 2022 14:52:16 +0000 (09:52 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 7 Nov 2022 19:25:51 +0000 (14:25 -0500)
commit1ef47f40dce3d5b176ddf76d57b5bfa2efb0b3c6
tree56bc52f2372ed6486eddde03af53e40fa66cb2c1
parent259d69c00b67c02a67f3bdbeeea71c2c0af76c35
checkpatch: better pattern for inline comments

checkpatch is unhappy about this line:

    WARNING: Block comments use a leading /* on a separate line
    #50: FILE: hw/acpi/nvdimm.c:1074:
    +                   aml_equal(aml_sizeof(pckg), aml_int(1)) /* 1 element? */));

but there's nothing wrong with it - the check is just too simplistic. It
will also miss lines which mix inline and block comments.

Instead, let's strip all inline comments from a line and then check for block
comments.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
scripts/checkpatch.pl