]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs: fix C++ compilation errors in xfs_fs.h
authorDarrick J. Wong <djwong@kernel.org>
Wed, 4 Sep 2024 10:49:52 +0000 (12:49 +0200)
committerCarlos Maiolino <cem@kernel.org>
Wed, 4 Sep 2024 10:49:52 +0000 (12:49 +0200)
commit1f19ad060df5325062d5a28a5aa78bf0266bf37d
tree1c617ad078b944d6f9fbc188686569641dfc5e9d
parent19c550c3960f6f8b2f3eb6ae95f2e4788da92c94
xfs: fix C++ compilation errors in xfs_fs.h

Source kernel commit: 64dfa18d6e322034c8a30b080f4c380a0b20bb7f

Several people reported C++ compilation errors due to things that C
compilers allow but C++ compilers do not.  Fix both of these problems,
and hope there aren't more of these brown paper bags in 2 months when we
finally get these fixes through the process into a released xfsprogs.

NOTE: I am submitting this bugfix over the objections of a former
maintainer, who insists that we should remove this function from the
published userspace ABI instead of fixing the C++ compilation errors.
No deprecation period, no discussion, just a hard drop of an already
provided and correct C function, which would be in contravention of
Linus' rules.  IOWs, removing ABI that have already shipped in a
released kernel requires a careful deprecation period, so I will let
that maintainer run that process.

Reported-by: kernel@mattwhitlock.name
Reported-by: sam@gentoo.org
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219203
Fixes: 233f4e12bbb2c ("xfs: add parent pointer ioctls")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
libxfs/xfs_fs.h