]> git.ipfire.org Git - thirdparty/qemu.git/commit
bsd-user/x86_64/target_arch_thread.h: Align stack
authorIlya Leoshkevich <iii@linux.ibm.com>
Wed, 31 Jul 2024 14:44:12 +0000 (16:44 +0200)
committerWarner Losh <imp@bsdimp.com>
Tue, 5 Nov 2024 03:26:40 +0000 (20:26 -0700)
commit1f31243a8c80fac27e52cc362cb1e2c922cf0e1b
tree290b827b2b75619b423f2f00fc0145598bffdf45
parentdaaf51001a13da007d7dde72e1ed3b06bc490791
bsd-user/x86_64/target_arch_thread.h: Align stack

bsd-user qemu-x86_64 almost immediately dies with:

    qemu: 0x4002201a68: unhandled CPU exception 0xd - aborting

on FreeBSD 14.1-RELEASE. This is an instruction that requires
alignment:

    (gdb) x/i 0x4002201a68
       0x4002201a68:        movaps %xmm0,-0x40(%rbp)

and the argument is not aligned:

    (gdb) p/x env->regs[5]
    $1 = 0x822443b58

A quick experiment shows that the userspace entry point expects
misaligned rsp:

    (gdb) starti
    (gdb) p/x $rsp
    $1 = 0x7fffffffeaa8

Emulate this behavior in bsd-user.

[[ applied Richard's suggestion ]]

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Signed-off-by: Warner Losh <imp@bsdimp.com>
bsd-user/x86_64/target_arch_thread.h