]> git.ipfire.org Git - thirdparty/glibc.git/commit
Fix segfault in maybe_script_execute.
authorStefan Liebler <stli@linux.ibm.com>
Thu, 6 Sep 2018 12:27:03 +0000 (14:27 +0200)
committerStefan Liebler <stli@linux.ibm.com>
Mon, 10 Sep 2018 12:22:52 +0000 (14:22 +0200)
commit1fe2b9ca8a50aaa789d72944b5a91f1d35337adc
tree1d637020bce4fbf6fec6e23092a19b13284e1a1f
parent0b79004569e5ce1669136b8c41564c3809730f15
Fix segfault in maybe_script_execute.

If glibc is built with gcc 8 and -march=z900,
the testcase posix/tst-spawn4-compat crashes with a segfault.

In function maybe_script_execute, the new_argv array is dynamically
initialized on stack with (argc + 1) elements.
The function wants to add _PATH_BSHELL as the first argument
and writes out of bounds of new_argv.
There is an off-by-one because maybe_script_execute fails to count
the terminating NULL when sizing new_argv.

ChangeLog:

* sysdeps/unix/sysv/linux/spawni.c (maybe_script_execute):
Increment size of new_argv by one.

(cherry picked from commit 28669f86f6780a18daca264f32d66b1428c9c6f1)
ChangeLog
sysdeps/unix/sysv/linux/spawni.c