]> git.ipfire.org Git - thirdparty/linux.git/commit
smb: client: fix memory leak during error handling for POSIX mkdir
authorJethro Donaldson <devel@jro.nz>
Wed, 14 May 2025 13:23:23 +0000 (01:23 +1200)
committerSteve French <stfrench@microsoft.com>
Thu, 15 May 2025 00:26:15 +0000 (19:26 -0500)
commit1fe4a44b7fa3955bcb7b4067c07b778fe90d8ee7
treee22246228790c15a0ea24dbdbb7eccfc704318f1
parent82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3
smb: client: fix memory leak during error handling for POSIX mkdir

The response buffer for the CREATE request handled by smb311_posix_mkdir()
is leaked on the error path (goto err_free_rsp_buf) because the structure
pointer *rsp passed to free_rsp_buf() is not assigned until *after* the
error condition is checked.

As *rsp is initialised to NULL, free_rsp_buf() becomes a no-op and the leak
is instead reported by __kmem_cache_shutdown() upon subsequent rmmod of
cifs.ko if (and only if) the error path has been hit.

Pass rsp_iov.iov_base to free_rsp_buf() instead, similar to the code in
other functions in smb2pdu.c for which *rsp is assigned late.

Cc: stable@vger.kernel.org
Signed-off-by: Jethro Donaldson <devel@jro.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2pdu.c