]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_admin: pick up log arguments correctly
authorDarrick J. Wong <djwong@kernel.org>
Thu, 15 Apr 2021 19:44:10 +0000 (15:44 -0400)
committerEric Sandeen <sandeen@sandeen.net>
Thu, 15 Apr 2021 19:44:10 +0000 (15:44 -0400)
commit1ff584b2411e80bd866e1d50e2eb51277306077d
tree4aa5a7aa734e0f2d7d3ee7ff43c08e4a9c5999cd
parentdcad5c60c59bfcdf4e27dc552b94591eced0a452
xfs_admin: pick up log arguments correctly

In commit ab9d8d69, we added support to xfs_admin to pass an external
log to xfs_db and xfs_repair.  Unfortunately, we didn't do this
correctly -- by appending the log arguments to DB_OPTS, we now guarantee
an invocation of xfs_db when we don't have any work for it to do.

Brian Foster noticed that this results in xfs/764 hanging fstests
because xfs_db (when not compiled with libeditline) will wait for input
on stdin.  I didn't notice because my build includes libeditline and my
test runner script does silly things with pipes such that xfs_db would
exit immediately.

Reported-by: Brian Foster <bfoster@redhat.com>
Fixes: ab9d8d69 ("xfs_admin: support adding features to V5 filesystems")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
db/xfs_admin.sh