]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MEDIUM: mux-h2: don't refrain from offering oneself a used buffer
authorWilly Tarreau <w@1wt.eu>
Wed, 29 May 2019 15:50:48 +0000 (17:50 +0200)
committerWilly Tarreau <w@1wt.eu>
Wed, 29 May 2019 15:54:35 +0000 (17:54 +0200)
commit201840abf121d3347fb284545ad88c47c814225d
tree9e826291fff2b588016cec00f7b2ccb0bc05d999
parent7f1265a238a1a7b1133bc8a2aaea80245c1a289f
BUG/MEDIUM: mux-h2: don't refrain from offering oneself a used buffer

Usually when calling offer_buffer(), we don't expect to offer it to
ourselves. But with h2 we have the same buffer_wait for the two directions
so we can unblock the recv path when completing a send(), or we can unblock
part of the mux buffer after sending the first few buffers that we managed
to collect. Thus it is important to always accept to wake up any requester.

A few parts of this patch could possibly be backported but earlier versions
already have other issues related to low-buffer condition so it's not sure
it's worth taking the risk to make things worse.
src/mux_h2.c