]> git.ipfire.org Git - thirdparty/git.git/commit
remote: fix tear down of struct remote
authorJacob Keller <jacob.keller@gmail.com>
Mon, 23 Jun 2025 23:11:30 +0000 (16:11 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 23 Jun 2025 23:38:56 +0000 (16:38 -0700)
commit2084f119b4d8252116493336f597d205cfa8f0b8
tree1da3bb90ca5b5e6ddb36a38adfc9bfd3d151c3a6
parentf62dcc7f30d16af29c0f707005aceb5eb6119279
remote: fix tear down of struct remote

The remote_clear() function failed to free the remote->push and
remote->fetch refspec fields.

This should be caught by the leak sanitizer. However, for callers which
use ``the_repository``, the values never go out of scope and the
sanitizer doesn't complain.

A future change is going to add a caller of read_config() for a
submodule repository structure, which would result in the leak sanitizer
complaining.

Fix remote_clear(), updating it to properly call refspec_clear() for
both the push and fetch members.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
remote.c