]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/misc/aspeed_scu: Correct minimum access size for AST2500 / AST2600
authorJoel Stanley <joel@jms.id.au>
Mon, 31 Mar 2025 23:04:44 +0000 (01:04 +0200)
committerCédric Le Goater <clg@redhat.com>
Tue, 1 Apr 2025 09:29:25 +0000 (11:29 +0200)
commit20ab88a9066bcacc28acbd7cbe2c617d90bfb27e
treec9e33dae1cb2c45ab178b4e18df98f83bfa80c2f
parentf0095c8ad93de7652aba36c4c713d9035417bea8
hw/misc/aspeed_scu: Correct minimum access size for AST2500 / AST2600

Guest code was performing a byte load to the SCU MMIO region, leading
to the guest code crashing (it should be using proper accessors, but
that is not Qemu's bug). Hardware and the documentation[1] both agree
that byte loads are okay, so change all of the aspeed SCU devices to
accept a minimum access size of 1.

[1] See the 'ARM Address Space Mapping' table in the ASPEED docs. This
is section 6.1 in the ast2400 and ast2700, and 7.1 in the ast2500 and
ast2600 datasheets.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2636
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Troy Lee <leetroy@gmail.com>
Message-ID: <20241118021820.4928-1-joel@jms.id.au>
[PMD: Rebased, only including SCU changes]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Link: https://lore.kernel.org/qemu-devel/20250331230444.88295-3-philmd@linaro.org
Signed-off-by: Cédric Le Goater <clg@redhat.com>
hw/misc/aspeed_scu.c