]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.
authorAmit Kapila <akapila@postgresql.org>
Mon, 14 Nov 2022 04:41:10 +0000 (10:11 +0530)
committerAmit Kapila <akapila@postgresql.org>
Mon, 14 Nov 2022 04:41:10 +0000 (10:11 +0530)
commit20c22333630111718bc97ce9a19b392f23e3c525
treed701e3669f469521c38e43ae0065aeb77ac7d4c8
parent58a45bb1d82b90e33a45b646717bf6a035256ded
Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.

During XLOG_HASH_SPLIT_ALLOCATE_PAGE replay, we were checking for a
cleanup lock on the new bucket page after acquiring an exclusive lock on
it and raising a PANIC error on failure. However, it is quite possible
that checkpointer can acquire the pin on the same page before acquiring a
lock on it, and then the replay will lead to an error. So instead, directly
acquire the cleanup lock on the new bucket page during
XLOG_HASH_SPLIT_ALLOCATE_PAGE replay operation.

Reported-by: Andres Freund
Author: Robert Haas
Reviewed-By: Amit Kapila, Andres Freund, Vignesh C
Backpatch-through: 11
Discussion: https://postgr.es/m/20220810022617.fvjkjiauaykwrbse@awork3.anarazel.de
src/backend/access/hash/hash_xlog.c
src/backend/access/hash/hashpage.c