]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
i2c: atr: Fix end of loop test in i2c_atr_find_mapping_by_addr()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 23 Apr 2025 08:21:18 +0000 (11:21 +0300)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Fri, 2 May 2025 14:39:54 +0000 (16:39 +0200)
commit20d5620e9b290aba2fa891b2ef2d4a695fdb2f57
treebbe39c3dbc03f038a7cef12f2f912d4c6f95d3ef
parent04668774f67f56df311d8ebe919b704ccd219ba3
i2c: atr: Fix end of loop test in i2c_atr_find_mapping_by_addr()

When the list_for_each_entry_reverse() exits without hitting a break
then the list cursor points to invalid memory.  So this check for
if (c2a->fixed) is checking bogus memory.  Fix it by using a "found"
variable to track if we found what we were looking for or not.

The list head (i2c_atr_chan.alias_pairs) is not a full entry, it's just
a struct list_head. When the for loop runs to completion, c2a doesn't
point to a struct i2c_atr_alias_pair, so you can't access c2a->fixed.

Fixes: c3f55241882b ("i2c: Support dynamic address translation")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
drivers/i2c/i2c-atr.c