]> git.ipfire.org Git - thirdparty/gcc.git/commit
libstdc++: Add missing constraints to std::bit_cast [PR105027]
authorJonathan Wakely <jwakely@redhat.com>
Wed, 23 Mar 2022 09:57:20 +0000 (09:57 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Mon, 4 Apr 2022 11:45:31 +0000 (12:45 +0100)
commit20f2303b0ce6bbe412e852e6423daabd04c39ebb
tree5e1c25c594cbef97b392792fe6a68cf8d230b5ec
parent6f8133689f439716455d17d333c238d85add23ed
libstdc++: Add missing constraints to std::bit_cast [PR105027]

Our std::bit_cast was relying on the compiler to check for errors inside
__builtin_bit_cast, instead of checking them as constraints. That means
std::bit_cast was not SFINAE-friendly.

This fix uses a requires-clause, so for old versions of Clang without
concepts support the function will still be unconstrained. At some point
in future we can remove the #ifdef __cpp_concepts check and rely on all
compilers having full concepts support in C++20 mode.

libstdc++-v3/ChangeLog:

PR libstdc++/105027
* include/std/bit (bit_cast): Add constraints.
* testsuite/26_numerics/bit/bit.cast/105027.cc: New test.

(cherry picked from commit 4894d69a1f37d54b6a612e58053db477ff5ba832)
libstdc++-v3/include/std/bit
libstdc++-v3/testsuite/26_numerics/bit/bit.cast/105027.cc [new file with mode: 0644]