]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/riscv/kvm: improve 'init_multiext_cfg' error msg
authorDaniel Henrique Barboza <dbarboza@ventanamicro.com>
Tue, 3 Oct 2023 13:21:47 +0000 (10:21 -0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Sun, 19 Nov 2023 18:15:06 +0000 (21:15 +0300)
commit221c0e142608a8567e7d3d82500dea84639587a7
tree4580622b9edad9fde5ee9628740e8264ae8c93ad
parent100feda604fbe389353bbce306fb3b28de70dbad
target/riscv/kvm: improve 'init_multiext_cfg' error msg

Our error message is returning the value of 'ret', which will be always
-1 in case of error, and will not be that useful:

qemu-system-riscv64: Unable to read ISA_EXT KVM register ssaia, error -1

Improve the error message by outputting 'errno' instead of 'ret'. Use
strerrorname_np() to output the error name instead of the error code.
This will give us what we need to know right away:

qemu-system-riscv64: Unable to read ISA_EXT KVM register ssaia, error code: ENOENT

Given that we're going to exit(1) in this condition instead of
attempting to recover, remove the 'kvm_riscv_destroy_scratch_vcpu()'
call.

Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231003132148.797921-2-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
(cherry picked from commit 082e9e4a58ba80ec056220a2f762a1c6b9a3a96c)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/riscv/kvm.c