]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mlxsw: spectrum_acl_bloom_filter: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 15 Jan 2019 23:05:39 +0000 (17:05 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Jan 2019 17:12:23 +0000 (09:12 -0800)
commit2285ec872d9dd5bd6a5c517cfd774be259e5f478
tree6763d89b7bef66e38328893e7440636debd5396c
parent590ce401c207fd944827eb5aa5e87d834eddb149
mlxsw: spectrum_acl_bloom_filter: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_bloom_filter.c