]> git.ipfire.org Git - thirdparty/valgrind.git/commit
Report track-fd errors for fd used which was not opened or already closed
authorAlexandra Hájková <ahajkova@redhat.com>
Wed, 16 Oct 2024 17:38:48 +0000 (13:38 -0400)
committerMark Wielaard <mark@klomp.org>
Thu, 31 Oct 2024 22:34:34 +0000 (23:34 +0100)
commit22971a15d62df6351ab97ea064eebd9bdcb4cf37
treef06b9a74d578170e89e338cebb4e32dbd6fef375
parent688f35dfdb5cc628a5c202069835a9a1390923a2
Report track-fd errors for fd used which was not opened or already closed

Add (optional) pathname, description, where_closed and where_opened
fields to struct FdBadUse. Print those fields when set in fd_pp_Error.

Add a new function ML_(find_OpenFd) that provides a recorded OpenFd
given an fd (or NULL when the fd was never recorded).

In ML_(fd_allowed) when using a file descriptor use ML_(find_OpenFd)
to see if the fd was ever created, if not create an "was never
created" FdBadUse error. If it was created, but already closed create
an "was closed already", filling in as much details as we can.

Add none/tests/use_after_close.vgtest to test, already closed, never
created, invalid, double (double) close and invalid close issues.

Adjust error message in none/tests/fdbaduse.stderr.exp.

https://bugs.kde.org/show_bug.cgi?id=493418
NEWS
coregrind/m_syswrap/syswrap-generic.c
none/tests/Makefile.am
none/tests/fdbaduse.stderr.exp
none/tests/use_after_close.c [new file with mode: 0644]
none/tests/use_after_close.stderr.exp [new file with mode: 0644]
none/tests/use_after_close.vgtest [new file with mode: 0644]