]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: pxa168_eth: Fix a potential data race in pxa168_eth_remove
authorPavel Andrianov <andrianov@ispras.ru>
Wed, 10 Mar 2021 08:10:46 +0000 (11:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Apr 2021 11:04:44 +0000 (13:04 +0200)
commit22dc793fda06faa76ff367cc25c8ca586dd638e5
tree9dbeb7ea566591cc7c8dae16b430c652b06ab584
parent073633cdd92bb5dd4ff42f8f0f4b5959fde050e7
net: pxa168_eth: Fix a potential data race in pxa168_eth_remove

[ Upstream commit 0571a753cb07982cc82f4a5115e0b321da89e1f3 ]

pxa168_eth_remove() firstly calls unregister_netdev(),
then cancels a timeout work. unregister_netdev() shuts down a device
interface and removes it from the kernel tables. If the timeout occurs
in parallel, the timeout work (pxa168_eth_tx_timeout_task) performs stop
and open of the device. It may lead to an inconsistent state and memory
leaks.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Pavel Andrianov <andrianov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/marvell/pxa168_eth.c