]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/arm: Un-inline access_secure_reg()
authorPeter Maydell <peter.maydell@linaro.org>
Wed, 12 Mar 2025 13:25:05 +0000 (13:25 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 14 Mar 2025 10:49:20 +0000 (10:49 +0000)
commit23560ada94bd22cb9e8d27b7e9389f6369f6d74d
treea8b0f00aa4ceb8a55555febf248544a3e6250965
parenteae0c3b659fbad5168c9bb9784b49d255185e35c
target/arm: Un-inline access_secure_reg()

We would like to move arm_el_is_aa64() to internals.h; however, it is
used by access_secure_reg().  Make that function not be inline, so
that it can stay in cpu.h.

access_secure_reg() is used only in two places:
 * in hflags.c
 * in the user-mode arm emulators, to decide whether to store
   the TLS value in the secure or non-secure banked field

The second of these is not on a super-hot path that would care about
the inlining (and incidentally will always use the NS banked field
because our user-mode CPUs never set ARM_FEATURE_EL3); put the
definition of access_secure_reg() in hflags.c, near its only use
inside target/arm.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
target/arm/cpu.h
target/arm/tcg/hflags.c