]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
projects / thirdparty / kernel / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c0c3a71) | patch
fs: Fix S_NOSEC handling
authorJan Kara <jack@suse.cz>
Thu, 21 May 2015 14:05:52 +0000 (16:05 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 23 Jun 2015 22:01:08 +0000 (18:01 -0400)
commit2426f3910069ed47c0cc58559a6d088af7920201
tree88c802202a7ae166f8da96ce3bcf43970eb314cdtree | snapshot
parentc0c3a718e3ab2430a52a60d614b109e5e48e83e2commit | diff
fs: Fix S_NOSEC handling

file_remove_suid() could mistakenly set S_NOSEC inode bit when root was
modifying the file. As a result following writes to the file by ordinary
user would avoid clearing suid or sgid bits.

Fix the bug by checking actual mode bits before setting S_NOSEC.

CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/inode.c diff | blob | blame | history
A mirror of Linus' kernel repository