]> git.ipfire.org Git - thirdparty/asterisk.git/commit
callerid: Logic error in checksum processing
authorRuss Meyerriecks <rmeyerreicks@digium.com>
Mon, 17 Mar 2014 21:14:21 +0000 (21:14 +0000)
committerRuss Meyerriecks <rmeyerreicks@digium.com>
Mon, 17 Mar 2014 21:14:21 +0000 (21:14 +0000)
commit2478dc0606399204afc3708fdd49a1b8f66c440f
treea4a0b1a18a765ed02e5fb492c60b54d6834487cd
parent1d8a661b3096d279fece5bce786592925b1e5ccd
callerid: Logic error in checksum processing

Callerid checksum-ing was being handled incorrectly here. When the checksum is
calculated to be 0x00, it will perform 0x100-0x00 which results in 0x100. This
value will then fail the otherwise correct callerid message.

This patch changes the logic to simply add the calculated checksum to the
transmitted 2's compliment checksum.

Review: https://reviewboard.asterisk.org/r/3356/
(closes issue ASTERISK-23488)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@410710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
main/callerid.c