]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf maps: Add missing unlock to maps__insert() error case
authorCengiz Can <cengiz@kernel.wtf>
Mon, 20 Jan 2020 14:15:54 +0000 (17:15 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Mar 2020 15:45:23 +0000 (16:45 +0100)
commit255780ee8eba4ddbc1ea7f38e2cd6cb88ff09401
tree663ff64ccde872428fbde5800dc53cae8791efcd
parent75286e2d2228265e59f9ee0576cf6f941c3c6143
perf maps: Add missing unlock to maps__insert() error case

commit 85fc95d75970ee7dd8e01904e7fb1197c275ba6b upstream.

`tools/perf/util/map.c` has a function named `maps__insert` that
acquires a write lock if its in multithread context.

Even though this lock is released when function successfully completes,
there's a branch that is executed when `maps_by_name == NULL` that
returns from this function without releasing the write lock.

Added an `up_write` to release the lock when this happens.

Fixes: a7c2b572e217 ("perf map_groups: Auto sort maps by name, if needed")
Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lore.kernel.org/lkml/20200120141553.23934-1-cengiz@kernel.wtf
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/perf/util/map.c