]> git.ipfire.org Git - thirdparty/linux.git/commit
perf/core: Fix pmus_lock vs. pmus_srcu ordering
authorPeter Zijlstra <peterz@infradead.org>
Mon, 4 Nov 2024 13:39:11 +0000 (14:39 +0100)
committerIngo Molnar <mingo@kernel.org>
Sat, 1 Mar 2025 18:38:42 +0000 (19:38 +0100)
commit2565e42539b120b81a68a58da961ce5d1e34eac8
tree2ca8d55b4f35154e2ccc73a3d40f8690a6b98d9b
parentdf87d843c6eb4dad31b7bf63614549dd3521fe71
perf/core: Fix pmus_lock vs. pmus_srcu ordering

Commit a63fbed776c7 ("perf/tracing/cpuhotplug: Fix locking order")
placed pmus_lock inside pmus_srcu, this makes perf_pmu_unregister()
trip lockdep.

Move the locking about such that only pmu_idr and pmus (list) are
modified while holding pmus_lock. This avoids doing synchronize_srcu()
while holding pmus_lock and all is well again.

Fixes: a63fbed776c7 ("perf/tracing/cpuhotplug: Fix locking order")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20241104135517.679556858@infradead.org
kernel/events/core.c