]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/pflash: fix block write start
authorGerd Hoffmann <kraxel@redhat.com>
Thu, 16 May 2024 12:12:37 +0000 (14:12 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 27 May 2024 04:37:34 +0000 (07:37 +0300)
commit2569dec929737f8bef4b9e1501ff0e41acf7af3c
tree160a7f0aa42e6823b23f57c77b327f900be9cd1d
parent2965ecc4870a55648508f2c5cbf63a02b9a55387
hw/pflash: fix block write start

Move the pflash_blk_write_start() call.  We need the offset of the
first data write, not the offset for the setup (number-of-bytes)
write.  Without this fix u-boot can do block writes to the first
flash block only.

While being at it drop a leftover FIXME.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2343
Fixes: 284a7ee2e290 ("hw/pflash: implement update buffer for block writes")
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240516121237.534875-1-kraxel@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
(cherry picked from commit 2563be6317fa9b5e661d79581538c704ecb90a1a)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/block/pflash_cfi01.c