]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Deprecate engine-wise ss cursors; repair mariadbconnector
authorMike Bayer <mike_mp@zzzcomputing.com>
Sun, 13 Sep 2020 14:36:16 +0000 (10:36 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sun, 13 Sep 2020 17:06:02 +0000 (13:06 -0400)
commit25b8e89d3d425656e51438b5cac7e6e1f2592817
tree66d2b0c07245f084ad4058c35c502d51332fd192
parenta4bfde4a18e50d93e44aec5c6216be8a6f9fbacb
Deprecate engine-wise ss cursors; repair mariadbconnector

The server_side_cursors engine-wide feature relies upon
regexp parsing of statements a well as general guessing as
to when the feature should be used.   This is not within the
2.0 way of doing things and should be removed.

Additionally, mariadbconnector defaults to unbuffered cursors;
add new cursor hooks so that mariadbconnector can specify
buffered or unbuffered cursors without too much difficulty.
This will also correctly default mariadbconnector to buffered
cursors which should repair the segfaults we've been getting.

Try to restore the assert_raises that was removed in
5b6dfc0c38bf1f01da4b8 to see if mariadbconnector segfaults
are resolved.

Change-Id: I77f1c972c742e40694972f578140bb0cac8c39eb
16 files changed:
doc/build/changelog/unreleased_14/sscursor.rst [new file with mode: 0644]
doc/build/core/connections.rst
lib/sqlalchemy/dialects/mysql/base.py
lib/sqlalchemy/dialects/mysql/mariadbconnector.py
lib/sqlalchemy/dialects/mysql/mysqldb.py
lib/sqlalchemy/dialects/mysql/pymysql.py
lib/sqlalchemy/dialects/postgresql/asyncpg.py
lib/sqlalchemy/dialects/postgresql/base.py
lib/sqlalchemy/dialects/postgresql/psycopg2.py
lib/sqlalchemy/engine/base.py
lib/sqlalchemy/engine/default.py
lib/sqlalchemy/orm/query.py
lib/sqlalchemy/testing/suite/test_results.py
test/dialect/mysql/test_dialect.py
test/dialect/mysql/test_types.py
test/engine/test_execute.py