]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
hwmon: (asus-ec-sensors) check sensor index in read_string()
authorAlexei Safin <a.safin@rosa.ru>
Thu, 24 Apr 2025 20:26:54 +0000 (23:26 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 2 May 2025 03:08:37 +0000 (20:08 -0700)
commit25be318324563c63cbd9cb53186203a08d2f83a1
tree6361928d0a5700395e85b336b1f42eb22602e1f9
parenta60d965931a8957f175cab2a5f594053fbdd9a58
hwmon: (asus-ec-sensors) check sensor index in read_string()

Prevent a potential invalid memory access when the requested sensor
is not found.

find_ec_sensor_index() may return a negative value (e.g. -ENOENT),
but its result was used without checking, which could lead to
undefined behavior when passed to get_sensor_info().

Add a proper check to return -EINVAL if sensor_index is negative.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d0ddfd241e57 ("hwmon: (asus-ec-sensors) add driver for ASUS EC")
Signed-off-by: Alexei Safin <a.safin@rosa.ru>
Link: https://lore.kernel.org/r/20250424202654.5902-1-a.safin@rosa.ru
[groeck: Return error code returned from find_ec_sensor_index]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/asus-ec-sensors.c