]> git.ipfire.org Git - thirdparty/grub.git/commit
term/ns8250: Fix incorrect usage of access_size
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 9 May 2023 03:01:11 +0000 (13:01 +1000)
committerDaniel Kiper <daniel.kiper@oracle.com>
Wed, 17 May 2023 16:19:02 +0000 (18:19 +0200)
commit260a9eab46e303bda1a0ae590e549dc5373e29a7
tree31ee628105e0e88e2e4d5259819e2c98d70bfaf6
parenta6eba8f1276e58d94b4134b2488768349c8f37dc
term/ns8250: Fix incorrect usage of access_size

The access_size is part of a union, so doesn't technically exist for
a PIO port (i.e., not MMIO), but we set it anyways.

This doesn't cause a bug today because the other leg of the union
doesn't have anything overlapping with it now, but it's bad, I will
punish myself for writing it that way :-) In the meantime, fix this
and actually name the struct inside the union for clarity of intent
and to avoid such issue in the future.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/term/ns8250.c
include/grub/serial.h