]> git.ipfire.org Git - thirdparty/qemu.git/commit
qga: Don't access global variable in run_agent_once()
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 5 Dec 2024 16:18:45 +0000 (17:18 +0100)
committerKonstantin Kostiuk <kkostiuk@redhat.com>
Wed, 18 Dec 2024 11:46:16 +0000 (13:46 +0200)
commit2657a92b5479c8705b128ed1e55feb8960ed498a
treeb3e320a8e7d627ab5a12649046e9cb286ffb907b
parent5788e9602416d24533a19d24b087d56a75119c36
qga: Don't access global variable in run_agent_once()

The run_agent_once() function is already given GAState via an
argument. There's no need to access the global ga_state variable
which points to the argument anyways (thanks to
initialize_agent()). Worse, some parts of the function use the
argument and the other use the global variable.  Stick with the
function argument.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Link: https://lore.kernel.org/r/8ae7f5d5032b14a5b956fe8aaf47bae5ca401699.1733414906.git.mprivozn@redhat.com
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
qga/main.c