]> git.ipfire.org Git - thirdparty/qemu.git/commit
Revert "replay: stop us hanging in rr_wait_io_event"
authorNicholas Piggin <npiggin@gmail.com>
Tue, 13 Aug 2024 20:23:21 +0000 (21:23 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 28 Aug 2024 05:37:29 +0000 (08:37 +0300)
commit26654442113aa9183a5262503c39adc6fe6d69e8
treea8c2670b07b17e702a1b4f0875dd7b0f58f93c36
parent71ce8dbc6bb90caf37813af2148a5a10ba0b9d8c
Revert "replay: stop us hanging in rr_wait_io_event"

This reverts commit 1f881ea4a444ef36a8b6907b0b82be4b3af253a2.

That commit causes reverse_debugging.py test failures, and does
not seem to solve the root cause of the problem x86-64 still
hangs in record/replay tests.

The problem with short-cutting the iowait that was taken during
record phase is that related events will not get consumed at the
same points (e.g., reading the clock).

A hang with zero icount always seems to be a symptom of an earlier
problem that has caused the recording to become out of synch with
the execution and consumption of events by replay.

Acked-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Message-Id: <20240813050638.446172-6-npiggin@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240813202329.1237572-14-alex.bennee@linaro.org>
(cherry picked from commit 94962ff00d09674047aed896e87ba09736cd6941)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2524
accel/tcg/tcg-accel-ops-rr.c
include/sysemu/replay.h
replay/replay.c