]> git.ipfire.org Git - people/ms/linux.git/commit
HID: zeroplus: validate output report details
authorKees Cook <keescook@chromium.org>
Wed, 11 Sep 2013 19:56:51 +0000 (19:56 +0000)
committerWilly Tarreau <w@1wt.eu>
Mon, 19 May 2014 05:53:27 +0000 (07:53 +0200)
commit267450c9146ff0e8c0aeb988d276f66f67af9500
tree38949072f655e2598ca60a92cf4c5678135e001b
parentdc4108776e19ac3f653c288138b1f23da655eb61
HID: zeroplus: validate output report details

commit 78214e81a1bf43740ce89bb5efda78eac2f8ef83 upstream

The zeroplus HID driver was not checking the size of allocated values
in fields it used. A HID device could send a malicious output report
that would cause the driver to write beyond the output report allocation
during initialization, causing a heap overflow:

[ 1442.728680] usb 1-1: New USB device found, idVendor=0c12, idProduct=0005
...
[ 1466.243173] BUG kmalloc-192 (Tainted: G        W   ): Redzone overwritten

CVE-2013-2889

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
[jmm: backport to 2.6.32]
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/hid/hid-zpff.c