]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix running out of file descriptors for spill files.
authorAmit Kapila <akapila@postgresql.org>
Thu, 2 Jan 2020 05:38:07 +0000 (11:08 +0530)
committerAmit Kapila <akapila@postgresql.org>
Thu, 2 Jan 2020 06:41:55 +0000 (12:11 +0530)
commit27b5f48c79f76f61d074849640513d855cb22c2a
tree0c6c84bcf25d7aeb5d876820645c389bfa3e4817
parentf512479c23e02ecd49aeb569064517b07de5cc2e
Fix running out of file descriptors for spill files.

Currently while decoding changes, if the number of changes exceeds a
certain threshold, we spill those to disk.  And this happens for each
(sub)transaction.  Now, while reading all these files, we don't close them
until we read all the files.  While reading these files, if the number of
such files exceeds the maximum number of file descriptors, the operation
errors out.

Use PathNameOpenFile interface to open these files as that internally has
the mechanism to release kernel FDs as needed to get us under the
max_safe_fds limit.

Reported-by: Amit Khandekar
Author: Amit Khandekar
Reviewed-by: Amit Kapila
Backpatch-through: 9.4
Discussion: https://postgr.es/m/CAJ3gD9c-sECEn79zXw4yBnBdOttacoE-6gAyP0oy60nfs_sabQ@mail.gmail.com
src/backend/replication/logical/reorderbuffer.c
src/test/recovery/t/006_logical_decoding.pl