]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rfs: annotate lockless accesses to sk->sk_rxhash
authorEric Dumazet <edumazet@google.com>
Tue, 6 Jun 2023 07:41:14 +0000 (07:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2023 08:59:55 +0000 (10:59 +0200)
commit28ac3cf2ac2140c073902a20220bf86a3f0df8ab
tree092d859cca9872a24e5c22d3fe27c872bd05d42a
parenta4c72805fda436a82bc31fe046a4f79c712045b6
rfs: annotate lockless accesses to sk->sk_rxhash

[ Upstream commit 1e5c647c3f6d4f8497dedcd226204e1880e0ffb3 ]

Add READ_ONCE()/WRITE_ONCE() on accesses to sk->sk_rxhash.

This also prevents a (smart ?) compiler to remove the condition in:

if (sk->sk_rxhash != newval)
sk->sk_rxhash = newval;

We need the condition to avoid dirtying a shared cache line.

Fixes: fec5e652e58f ("rfs: Receive Flow Steering")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/sock.h