]> git.ipfire.org Git - thirdparty/nftables.git/commit
parser_bison: close chain scope before chain release
authorFlorian Westphal <fw@strlen.de>
Wed, 13 Dec 2023 10:09:58 +0000 (11:09 +0100)
committerFlorian Westphal <fw@strlen.de>
Wed, 13 Dec 2023 11:08:17 +0000 (12:08 +0100)
commit28b3bbec5a97aaa57f7138fee8b2f22ff0e5b960
tree08b6dda28fac4b1ada6de884d8e7ff6c0c40f0f2
parent037d58a27d675802286aafb23e409b8c1d3eef56
parser_bison: close chain scope before chain release

cmd_alloc() will free the chain, so we must close the scope opened
in chain_block_alloc beforehand.

The included test file will cause a use-after-free because nft attempts
to search for an identifier in a scope that has been freed:

AddressSanitizer: heap-use-after-free on address 0x618000000368 at pc 0x7f1cbc0e6959 bp 0x7ffd3ccb7850 sp 0x7ffd3ccb7840
    #0 0x7f1cbc0e6958 in symbol_lookup src/rule.c:629
    #1 0x7f1cbc0e66a1 in symbol_get src/rule.c:588
    #2 0x7f1cbc120d67 in nft_parse src/parser_bison.y:4325

Fixes: a66b5ad9540d ("src: allow for updating devices on existing netdev chain")
Signed-off-by: Florian Westphal <fw@strlen.de>
src/parser_bison.y
tests/shell/testcases/bogons/nft-f/use_after_free_on_chain_removal [new file with mode: 0644]