]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MEDIUM: server: fix potential null-deref after previous fix
authorWilly Tarreau <w@1wt.eu>
Thu, 22 May 2025 16:09:12 +0000 (18:09 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 22 May 2025 16:09:12 +0000 (18:09 +0200)
commit28c7a22790a587c6a3ee1652188ad6786d59b687
tree4a03d457bbfc196ea1d319e81d1b4fcb666b4913
parentb40ce97ecca0e43c45f6a15e3a7184436d5cb467
BUG/MEDIUM: server: fix potential null-deref after previous fix

A valid build warning was reported in the CI with latest commit b40ce97ecc
("BUG/MEDIUM: server: fix crash after duplicate GUID insertion"). Indeed,
if the first test in the function fails, we branch to the err label
with guid==NULL and will crash there. Let's just test guid before
dereferencing it for freeing.

This needs to be backported to 3.0 as well since the commit above was
meant to go there.
src/guid.c