]> git.ipfire.org Git - thirdparty/openvpn.git/commit
dco-win: fix broken ASSERT in dco_new_key
authorLev Stipakov <lev@openvpn.net>
Mon, 29 Sep 2025 15:28:41 +0000 (17:28 +0200)
committerGert Doering <gert@greenie.muc.de>
Mon, 29 Sep 2025 18:48:32 +0000 (20:48 +0200)
commit290a14cd9edf95f07940f63993c290dc045c2a44
treeb4d0e46614600df2cc9c8fc693403dfe0f716d57
parent36a09c8dbfb68c9df745943886dc974513998c07
dco-win: fix broken ASSERT in dco_new_key

Commit

  e77c343 ("dco_win: In dco_new_key, document size assumptions for the integer casts")

has added an ASSERT on key-id, but didn't take into account that
key-id 0 is a perfectly valid value and is the first key-id. This
essentially broke dco-win.

Fix by adjusting ASSERT to >= 0.

Change-Id: I3b1243461ec9b6e85897f452f78dc4b05f7e126d
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1223
Message-Id: <20250929152841.177424-1-frank@lichtenheld.com>
URL: https://sourceforge.net/p/openvpn/mailman/message/59240115/
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/dco_win.c