]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: wacom: Hardcode (non-inverted) AES pens as BTN_TOOL_PEN
authorJason Gerecke <jason.gerecke@wacom.com>
Wed, 9 Oct 2024 16:41:21 +0000 (09:41 -0700)
committerJiri Kosina <jkosina@suse.com>
Fri, 11 Oct 2024 09:12:19 +0000 (11:12 +0200)
commit2934b12281abf4eb5f915086fd5699de5c497ccd
treee55d0c3f01d528cb0b3e22ea2ed3657a736972a1
parentc56f9ecb7fb6a3a90079c19eb4c8daf3bbf514b3
HID: wacom: Hardcode (non-inverted) AES pens as BTN_TOOL_PEN

Unlike EMR tools which encode type information in their tool ID, tools
for AES sensors are all "generic pens". It is inappropriate to make use
of the wacom_intuos_get_tool_type function when dealing with these kinds
of devices. Instead, we should only ever report BTN_TOOL_PEN or
BTN_TOOL_RUBBER, as depending on the state of the Eraser and Invert
bits.

Reported-by: Daniel Jutz <daniel@djutz.com>
Closes: https://lore.kernel.org/linux-input/3cd82004-c5b8-4f2a-9a3b-d88d855c65e4@heusel.eu/
Bisected-by: Christian Heusel <christian@heusel.eu>
Fixes: 9c2913b962da ("HID: wacom: more appropriate tool type categorization")
Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/1041
Link: https://github.com/linuxwacom/input-wacom/issues/440
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Cc: stable@vger.kernel.org
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_wac.c