]> git.ipfire.org Git - people/arne_f/kernel.git/commit
tun: fix rcu_read_lock imbalance in tun_build_skb
authorXin Long <lucien.xin@gmail.com>
Sun, 19 Nov 2017 11:31:04 +0000 (19:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Dec 2017 14:07:58 +0000 (15:07 +0100)
commit29d631e5941366ee5eb50b3b592ca99186115a63
tree938103a4f850f7e4ad4f157351c0bedf937d1c59
parent7afe2e668ee2b1f465dcccb942da9d8f8d873f20
tun: fix rcu_read_lock imbalance in tun_build_skb

[ Upstream commit 654d573845f35017dc397840fa03610fef3d08b0 ]

rcu_read_lock in tun_build_skb is used to rcu_dereference tun->xdp_prog
safely, rcu_read_unlock should be done in every return path.

Now I could see one place missing it, where it returns NULL in switch-case
XDP_REDIRECT,  another palce using rcu_read_lock wrongly, where it returns
NULL in if (xdp_xmit) chunk.

So fix both in this patch.

Fixes: 761876c857cb ("tap: XDP support")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/tun.c