]> git.ipfire.org Git - thirdparty/git.git/commit
builtin/repack.c: be more conservative with unsigned overflows
authorTaylor Blau <me@ttaylorr.com>
Fri, 5 Mar 2021 15:21:56 +0000 (10:21 -0500)
committerJunio C Hamano <gitster@pobox.com>
Fri, 5 Mar 2021 19:33:52 +0000 (11:33 -0800)
commit2a15964128edd08278efeacc75e75c77cfdde77e
treefb84aacc8e8cf1b8a9e52f94931a20bde949d079
parent13d746a303592068826824b30c47941fb328c8a7
builtin/repack.c: be more conservative with unsigned overflows

There are a number of places in the geometric repack code where we
multiply the number of objects in a pack by another unsigned value. We
trust that the number of objects in a pack is always representable by a
uint32_t, but we don't necessarily trust that that number can be
multiplied without overflow.

Sprinkle some unsigned_add_overflows() and unsigned_mult_overflows() in
split_pack_geometry() to check that we never overflow any unsigned types
when adding or multiplying them.

Arguably these checks are a little too conservative, and certainly they
do not help the readability of this function. But they are serving a
useful purpose, so I think they are worthwhile overall.

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/repack.c